Skip to content

Move dependent options to default preset #10805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

Move dependent options to default preset #10805

merged 1 commit into from
May 13, 2025

Conversation

jathu
Copy link
Contributor

@jathu jathu commented May 11, 2025 •
edited by pytorch-bot bot
Loading

Summary

  • Move the simple options to default preset. This shouldn't change any build configurations

Test plan

CI

cc @larryliu0820

@jathu jathu added module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch ciflow/trunk ciflow/binaries topic: not user facing labels May 11, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented May 11, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10805

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 3a9fc04 with merge base 473c77b (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 11, 2025
@jathu jathu force-pushed the jathu/move-dep-option branch from fbe2c92 to 5fcd12a Compare May 11, 2025 00:43
@jathu jathu force-pushed the jathu/move-simple-option branch from 6eebdd1 to 3434d78 Compare May 12, 2025 16:56
@jathu jathu force-pushed the jathu/move-dep-option branch from 5fcd12a to b79fe0c Compare May 12, 2025 16:57
@jathu jathu force-pushed the jathu/move-simple-option branch from 3434d78 to f375589 Compare May 12, 2025 21:03
@jathu jathu force-pushed the jathu/move-dep-option branch from b79fe0c to 5e2c62d Compare May 12, 2025 21:04
@jathu jathu force-pushed the jathu/move-simple-option branch from f375589 to fe3c2ec Compare May 12, 2025 21:51
@jathu jathu force-pushed the jathu/move-dep-option branch from 5e2c62d to 9b30cf9 Compare May 12, 2025 21:51
@jathu jathu force-pushed the jathu/move-simple-option branch from fe3c2ec to c7a6437 Compare May 12, 2025 23:17
@jathu jathu force-pushed the jathu/move-dep-option branch 2 times, most recently from c86761d to 89dd82a Compare May 13, 2025 00:12
@jathu jathu force-pushed the jathu/move-simple-option branch from c7a6437 to 81af638 Compare May 13, 2025 00:18
@jathu jathu force-pushed the jathu/move-dep-option branch from 89dd82a to a6e9085 Compare May 13, 2025 00:18
@jathu jathu marked this pull request as ready for review May 13, 2025 00:26
Base automatically changed from jathu/move-simple-option to main May 13, 2025 02:47
@jathu jathu requested a review from tarun292 as a code owner May 13, 2025 02:47
@jathu jathu force-pushed the jathu/move-dep-option branch from a6e9085 to 3a9fc04 Compare May 13, 2025 02:47
@jathu jathu added release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc. and removed topic: not user facing labels May 13, 2025
@jathu jathu merged commit f8e7264 into main May 13, 2025
192 of 198 checks passed
@jathu jathu deleted the jathu/move-dep-option branch May 13, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larryliu0820 larryliu0820 larryliu0820 approved these changes

@tarun292 tarun292 Awaiting requested review from tarun292

Assignees
No one assigned
Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch release notes: build Changes related to build, including dependency upgrades, build flags, optimizations, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jathu @larryliu0820 @facebook-github-bot